improving scroll behaviour on mobile devices

Signed-off-by: Stephan Richter <s.richter@srsoftware.de>

core/src/main/java/de/srsoftware/umbrella/core/BaseHandler.java

@@ -2,9 +2,11 @@
 package de.srsoftware.umbrella.core;
 
 import static de.srsoftware.tools.Optionals.nullable;
+import static de.srsoftware.umbrella.core.ModuleRegistry.translator;
 import static java.lang.System.Logger.Level.DEBUG;
 import static java.lang.System.Logger.Level.WARNING;
 import static java.net.HttpURLConnection.*;
+import static java.text.MessageFormat.format;
 
 import com.sun.net.httpserver.HttpExchange;
 import de.srsoftware.tools.Path;
@@ -72,7 +74,9 @@ public abstract class BaseHandler extends PathHandler {
 	}
 
 	public boolean send(HttpExchange ex, UmbrellaException e) throws IOException {
-		return sendContent(ex,e.statusCode(),e.getMessage());
+		String lang = languages(ex).stream().findFirst().orElse(null);
+		var translatedMessage = translator().translate(lang,e.getMessage());
+		return sendContent(ex,e.statusCode(),format(translatedMessage,e.fills()));
 	}
 
 	public boolean unauthorized(HttpExchange ex) throws IOException {

core/src/main/java/de/srsoftware/umbrella/core/exceptions/UmbrellaException.java

@@ -13,13 +13,15 @@ import static java.text.MessageFormat.format;
 
 public class UmbrellaException extends RuntimeException{
 	private final int statusCode;
+	private Object[] fills;
 
 	public UmbrellaException(String message, Object ... fills){
 		this(HTTP_SERVER_ERROR,message,fills);
 	}
 
 	public UmbrellaException(int statusCode, String message, Object ... fills){
-		super(fills == null || fills.length<1 ? message : format(message,fills));
+		super(message);
+		this.fills = fills;
 		this.statusCode = statusCode;
 	}
 
@@ -34,6 +36,10 @@ public class UmbrellaException extends RuntimeException{
 		return new UmbrellaException(message,fills);
 	}
 
+	public Object[] fills(){
+		return fills;
+	}
+
 	public static UmbrellaException forbidden(String message, Object... fills) {
 		return new UmbrellaException(HTTP_FORBIDDEN,message,fills);
 	}

frontend/src/Components/LineEditor.svelte

@@ -22,8 +22,12 @@
     async function applyEdit(){
         let success = await onSet(editValue);
         if (success) {
+            if (success == 'reset'){
+                editValue = value;
+            } else {
                 value   = editValue;
-            editing=false;
+            }
+            editing = false;
         } else {
             editValue = value;
         }
@@ -36,7 +40,7 @@
     }
 
     function measured(evt,duration,d){
-        if (d > 100) return;
+        if (d > 10) return;
         if (duration < 500){
             onclick(evt);
         } else {

frontend/src/Components/Menu.svelte

@@ -50,7 +50,7 @@ onMount(fetchModules);
     }
 </style>
 
-<nav class={expand?"":"collapsed"}>
+<nav class={expand?"expanded":"collapsed"}>
     <form onsubmit={search}>
         <input type="text" bind:value={key} />
         <button type="submit">{t('search')}</button>

frontend/src/routes/project/Kanban.svelte

@@ -78,8 +78,10 @@
             if (!tasks[user_id][state]) tasks[user_id][state] = {};
             tasks[user_id][state][task.id] = task;
             yikes();
+            return 'reset';
         } else {
             error(resp);
+            return false;
         }
     }
 
@@ -255,7 +257,7 @@
                     {/if}
                 {/each}
                 <div class="add_task">
-                    <LineEditor value={t('add_object',{object:t('task')})} editable={true} onSet={(name) => create(name,uid,state)}/>
+                    <LineEditor value={t('add_object',{object:t('task')})} editable={true} onSet={(name) => create(name,u.id,state)}/>
                 </div>
             </div>
         {/each}

frontend/src/routes/task/EasyList.svelte

@@ -73,7 +73,7 @@
     }
 
     function measured(evt,duration,d){
-        if (d > 100) return;
+        if (d > 10) return;
         if (duration < 500){
             onclick(evt);
         } else {

project/src/main/java/de/srsoftware/umbrella/project/SqliteDb.java

@@ -137,7 +137,7 @@ CREATE TABLE IF NOT EXISTS {0} (
 			if (rs.next()) project = Project.of(rs);
 			rs.close();
 
-			if (project == null) throw UmbrellaException.notFound("No project found for id {0}",projectId);
+			if (project == null) throw UmbrellaException.notFound("no_project_for_id",projectId);
 
 			rs = select(ALL).from(TABLE_CUSTOM_STATES).where(PROJECT_ID,equal(projectId)).exec(db);
 			var states = project.allowedStates();

task/src/main/java/de/srsoftware/umbrella/task/SqliteDb.java

@@ -270,7 +270,7 @@ CREATE TABLE IF NOT EXISTS {0} (
 	public Task load(long taskId) throws UmbrellaException {
 		var map = load(List.of(taskId));
 		var task = map.get(taskId);
-		if (task == null) throw UmbrellaException.notFound("No task found for id {0}",taskId);
+		if (task == null) throw UmbrellaException.notFound("no_task_for_id",taskId);
 		return task;
 	}
 

translations/src/main/resources/de.json

@@ -183,6 +183,8 @@
   "new_password": "neues Passwort",
   "new_property": "neue Eigenschaft",
   "no_company": "keine Firma",
+  "no_project_for_id": "Kein Projekt mit ID {0} gefunden!",
+  "no_task_for_id": "Keine Aufgabe mit ID {0} gefunden!",
   "note": "Notiz",
   "notes": "Notizen",
   "not_recent_version": "Die ist nicht die neuste Version dieser Seite!",

translations/src/main/resources/en.json

@@ -183,6 +183,8 @@
   "new_password": "new password",
   "new_property": "new property",
   "no_company": "no company",
+  "no_project_for_id": "No project found for id {0}",
+  "no_task_for_id": "No task found for id {0}",
   "note": "note",
   "notes": "notes",
   "not_recent_version": "This is not the current version of this page!",

web/src/main/resources/web/css/bloodshed.css

@@ -16,6 +16,10 @@ body {
     background-attachment: fixed;
 }
 
+code {
+    font-size: 16px;
+}
+
 fieldset {
     border: 1px solid;
     border-radius: 4px;
@@ -427,14 +431,14 @@ a.wikilink{
 }
 
 @media screen and (min-width: 900px) {
-	#app nav button.symbol{
+	#app nav > button.symbol{
 		display: none;
 	}
 }
 
 @media screen and (max-width: 900px) {
 	body{
-		padding-top: 13px;
+		padding-top: 30px;
 	}
 	#app nav{
         grid-template-columns: 33% 34% 33%;
@@ -443,7 +447,6 @@ a.wikilink{
 		position: absolute;
 		left: 0;
 		right: 0;
-
     }
     #app nav form{
     	grid-column-end: span 2;
@@ -462,9 +465,20 @@ a.wikilink{
 	  text-align: center;
 	  border: 1px solid;
 	  margin: 5px;
-	  padding: 15px 0;
 	  border-radius: 7px;
 	}
+
+	#app nav a::before {
+      font-size: 30px;
+    }
+	#app nav .timetracking{
+		grid-column-end: span 3;
+		font-size: 19px;
+		text-align: center;
+	}
+	#app nav.expanded .timetracking{
+		display: none;
+	}
 }
 
 
@@ -506,6 +520,9 @@ a.wikilink{
     #app nav .logout{
     	grid-column-end: 3;
     }
+    #app nav.expanded .timetracking{
+    	grid-column-end: span 2;
+    }
 }
 
 fieldset.vcard{

web/src/main/resources/web/css/default.css

@@ -16,6 +16,10 @@ body {
     background-attachment: fixed;
 }
 
+code {
+    font-size: 16px;
+}
+
 fieldset {
     border: 1px solid;
     border-radius: 4px;
@@ -505,7 +509,7 @@ a.wikilink{
 }
 
 @media screen and (min-width: 900px) {
-	#app nav button.symbol{
+	#app nav > button.symbol{
 		display: none;
 	}
 }
@@ -545,11 +549,42 @@ a.wikilink{
 	#app nav a::before {
       font-size: 30px;
     }
+	#app nav .timetracking{
+		grid-column-end: span 3;
+		font-size: 19px;
+		text-align: center;
+	}
+	#app nav.expanded .timetracking{
+		display: none;
+	}
+    .grid3 {
+        grid-template-columns: auto auto;
+    }
+
+    .grid3 .properties{
+    	grid-column-end: span 2;
+    	order: 1;
+    }
+    .grid3 .tags{
+		order: 2;
+	}
+    .grid3 .notes{
+    	grid-column-end: span 2;
+    	order: 3;
+    }
+
+	.grid3 .locations{
+		order: 5;
+	}
+	.grid3 .items{
+		order: 6;
+	}
 }
 
 
 @media screen and (max-width: 600px) {
-    .grid2{
+    .grid2,
+    .grid3{
         display: grid;
         grid-template-columns: auto;
     }
@@ -580,12 +615,18 @@ a.wikilink{
 	#app nav{
 		grid-template-columns: auto auto;
 	}
-	#app nav form{
+	#app nav form,
+    .grid3 .notes,
+    .grid3 .tags,
+    .grid3 .properties{
 		grid-column-end: span 1;
 	}
     #app nav .logout{
     	grid-column-end: 3;
     }
+    #app nav.expanded .timetracking{
+    	grid-column-end: span 2;
+    }
 }
 
 fieldset.vcard{

web/src/main/resources/web/css/winter.css

@@ -16,6 +16,9 @@ body {
     background-attachment: fixed;
 }
 
+code {
+    font-size: 16px;
+}
 fieldset {
     border: 1px solid;
     border-radius: 4px;
@@ -427,14 +430,14 @@ a.wikilink{
 }
 
 @media screen and (min-width: 900px) {
-	#app nav button.symbol{
+	#app nav > button.symbol{
 		display: none;
 	}
 }
 
 @media screen and (max-width: 900px) {
 	body{
-		padding-top: 13px;
+		padding-top: 30px;
 	}
 	#app nav{
         grid-template-columns: 33% 34% 33%;
@@ -443,7 +446,6 @@ a.wikilink{
 		position: absolute;
 		left: 0;
 		right: 0;
-
     }
     #app nav form{
     	grid-column-end: span 2;
@@ -462,9 +464,20 @@ a.wikilink{
 	  text-align: center;
 	  border: 1px solid;
 	  margin: 5px;
-	  padding: 15px 0;
 	  border-radius: 7px;
 	}
+
+	#app nav a::before {
+      font-size: 30px;
+    }
+	#app nav .timetracking{
+		grid-column-end: span 3;
+		font-size: 19px;
+		text-align: center;
+	}
+	#app nav.expanded .timetracking{
+		display: none;
+	}
 }
 
 
@@ -506,6 +519,9 @@ a.wikilink{
     #app nav .logout{
     	grid-column-end: 3;
     }
+    #app nav.expanded .timetracking{
+    	grid-column-end: span 2;
+    }
 }
 
 fieldset.vcard{