From f402122d0c15b78e129acdd99e6efa0ed9d2b8db Mon Sep 17 00:00:00 2001
From: Stephan Richter <s.richter@srsoftware.de>
Date: Wed, 28 Jan 2026 15:22:20 +0100
Subject: [PATCH] improved search: motes now showing name/title of related
 entities

Signed-off-by: Stephan Richter <s.richter@srsoftware.de>
---
 frontend/src/routes/search/Search.svelte      | 28 +++++++++++++++++--
 .../umbrella/stock/StockModule.java           | 18 +++++++++++-
 2 files changed, 42 insertions(+), 4 deletions(-)

diff --git a/frontend/src/routes/search/Search.svelte b/frontend/src/routes/search/Search.svelte
index bdde9757..dea0c210 100644
--- a/frontend/src/routes/search/Search.svelte
+++ b/frontend/src/routes/search/Search.svelte
@@ -1,7 +1,7 @@
 <script>
     import { onMount }       from 'svelte';
     import { useTinyRouter } from 'svelte-tiny-router';
-    import { api, post, target }   from '../../urls.svelte.js';
+    import { api, get, post, target }   from '../../urls.svelte.js';
     import { error, warn, yikes }  from '../../warn.svelte';
     import { t }             from '../../translations.svelte.js';
     import { display }       from '../../time.svelte';
@@ -52,6 +52,20 @@
         post(api('wiki/search'    ),data).then(handleWikiPages);
     }
 
+    async function getTitle(key,module,entity_id){
+
+        get(api(module+'/'+entity_id)).then(res => setTitle(res,key,module))
+    }
+
+    async function setTitle(resp,key,module){
+        if (resp.ok){
+            const json = await resp.json();
+            if (json.name) notes[key].title = t(module)+": "+json.name;
+            if (json.title) notes[key].title = t(module)+": "+json.title;
+        }
+
+    }
+
     function onclick(e){
         e.preventDefault();
         var target = e.target;
@@ -95,7 +109,15 @@
         quitOne();
         if (resp.ok){
             const json = await resp.json();
-            notes = Object.keys(json).length ? json : null;
+            if ( Object.keys(json).length ) {
+                for (let key of Object.keys(json)){
+                    let module = json[key].module;
+                    let entity_id = json[key].entity_id;
+                    json[key].title = t(module)+' '+entity_id;
+                    getTitle(key,module,entity_id);
+                }
+                notes = json;
+            } else notes = null;
         } else {
             error(resp);
         }
@@ -317,7 +339,7 @@
         {#each Object.values(notes) as note}
         <li>
             <b>
-                <a href="/{note.module}/{note.entity_id}/view" {onclick} >{t(note.module)} {note.entity_id}:</a>
+                <a href="/{note.module}/{note.entity_id}/view" {onclick} >{note.title}</a>
             </b>
             {@html target(note.text.rendered)}
         </li>
diff --git a/stock/src/main/java/de/srsoftware/umbrella/stock/StockModule.java b/stock/src/main/java/de/srsoftware/umbrella/stock/StockModule.java
index 4b46a2b6..bd8d574d 100644
--- a/stock/src/main/java/de/srsoftware/umbrella/stock/StockModule.java
+++ b/stock/src/main/java/de/srsoftware/umbrella/stock/StockModule.java
@@ -132,7 +132,23 @@ public class StockModule extends BaseHandler implements StockService {
 						yield super.doGet(path,ex);
 					}
 				}
-				case null, default -> super.doGet(path,ex);
+				case null -> super.doGet(path,ex);
+				default -> {
+					try {
+						var id = Long.parseLong(head);
+						Item item = stockDb.loadItem(id);
+						Owner owner = item.owner().resolve();
+						if (owner instanceof Company company) {
+							if (!companyService().membership(company.id(),user.get().id())) throw forbidden("You are not allowed to access {0}",OBJECT);
+						}
+						if (owner instanceof UmbrellaUser u){
+							if (u.id() != user.get().id()) throw forbidden("You are not allowed to access {0}",OBJECT);
+						}
+						yield sendContent(ex,item);
+				} catch (NumberFormatException nfe){
+						yield super.doGet(path,ex);
+					}
+				}
 			};
 		} catch (UmbrellaException e){
 			return send(ex,e);