From 53db593936e5e398b9384421a36ee37e3dae0c9d Mon Sep 17 00:00:00 2001 From: Stephan Richter Date: Mon, 25 Aug 2025 18:27:08 +0200 Subject: [PATCH] implemented test to prevent blank tags --- frontend/src/routes/tags/TagList.svelte | 1 + tags/src/main/java/de/srsoftware/umbrella/tags/TagModule.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/frontend/src/routes/tags/TagList.svelte b/frontend/src/routes/tags/TagList.svelte index d0fe7f3..5a7fa61 100644 --- a/frontend/src/routes/tags/TagList.svelte +++ b/frontend/src/routes/tags/TagList.svelte @@ -17,6 +17,7 @@ let router = useTinyRouter(); async function addTag(){ + if (!newTag) return; if (!id) { // when creating elements, they don`t have an id, yet tags.push(newTag); diff --git a/tags/src/main/java/de/srsoftware/umbrella/tags/TagModule.java b/tags/src/main/java/de/srsoftware/umbrella/tags/TagModule.java index 6f047f6..bac3108 100644 --- a/tags/src/main/java/de/srsoftware/umbrella/tags/TagModule.java +++ b/tags/src/main/java/de/srsoftware/umbrella/tags/TagModule.java @@ -93,7 +93,7 @@ public class TagModule extends BaseHandler implements TagService { var head = path.pop(); long entityId = Long.parseLong(head); var json = json(ex); - if (!(json.has(TAG) && json.get(TAG) instanceof String tag)) throw missingFieldException(TAG); + if (!(json.has(TAG) && json.get(TAG) instanceof String tag && !tag.isBlank())) throw missingFieldException(TAG); List userList = null; if (!json.has(USER_LIST)) throw missingFieldException(USER_LIST); var ul = json.isNull(USER_LIST) ? null : json.get(USER_LIST);