From 49461199cd1e9b5af2c2e686990bd0cd94626bb5 Mon Sep 17 00:00:00 2001
From: Stephan Richter <s.richter@srsoftware.de>
Date: Thu, 28 Aug 2025 10:18:50 +0200
Subject: [PATCH] implemented editor for times

---
 .../srsoftware/umbrella/core/model/Time.java  | 17 +++++++--
 frontend/src/Components/DateTimeEditor.svelte | 24 ------------
 .../src/Components/TimeRecordEditor.svelte    | 37 ++++++++++++++++++
 frontend/src/routes/time/Index.svelte         | 38 ++++++++-----------
 translations/src/main/resources/de.json       |  1 +
 5 files changed, 67 insertions(+), 50 deletions(-)
 delete mode 100644 frontend/src/Components/DateTimeEditor.svelte
 create mode 100644 frontend/src/Components/TimeRecordEditor.svelte

diff --git a/core/src/main/java/de/srsoftware/umbrella/core/model/Time.java b/core/src/main/java/de/srsoftware/umbrella/core/model/Time.java
index 639d265..efaec7d 100644
--- a/core/src/main/java/de/srsoftware/umbrella/core/model/Time.java
+++ b/core/src/main/java/de/srsoftware/umbrella/core/model/Time.java
@@ -108,12 +108,21 @@ public class Time implements Mappable{
 		);
 	}
 
+	private LocalDateTime parse(String time){
+		if (time.contains("T")) return LocalDateTime.parse(time);
+		return LocalDateTime.parse(time,DT);
+	}
+
 	public Time patch(JSONObject json) {
 		if (json.has(SUBJECT) && json.get(SUBJECT) instanceof String s) subject = s;
-		if (json.has(DESCRIPTION) && json.get(DESCRIPTION) instanceof String d) description = d;
-		if (json.has(START_TIME) && json.get(START_TIME) instanceof String st) start = LocalDateTime.parse(st, DT);
-		if (json.has(END_TIME) && json.get(END_TIME) instanceof String e) end = LocalDateTime.parse(e,DT);
-		if (end != null && !start.isBefore(end)) throw UmbrellaException.invalidFieldException(END_TIME,"after start_time");
+		if (json.has(DESCRIPTION)) {
+			var o = json.get(DESCRIPTION);
+			if (o instanceof JSONObject nested && nested.get(SOURCE) instanceof String src) o = src;
+			if (o instanceof String d) description = d;
+		}
+		if (json.has(START_TIME) && json.get(START_TIME) instanceof String st) start = parse(st);
+		if (json.has(END_TIME) && json.get(END_TIME) instanceof String e) end = parse(e);
+		if (end != null && end.isBefore(start)) throw UmbrellaException.invalidFieldException(END_TIME,"after start_time");
 		return this;
 	}
 
diff --git a/frontend/src/Components/DateTimeEditor.svelte b/frontend/src/Components/DateTimeEditor.svelte
deleted file mode 100644
index b2d23af..0000000
--- a/frontend/src/Components/DateTimeEditor.svelte
+++ /dev/null
@@ -1,24 +0,0 @@
-<script>
-
-    let { onSet = (dateTime) => {}, value = ' ' } = $props();
-
-    let date = $state(value.split(' ')[0]);
-    let time = $state(value.split(' ')[1]);
-
-    console.log({date:date,time:time,value:value});
-
-    function handleSubmit(e){
-        e.preventDefault();
-        onSet(`${date} ${time}`);
-    }
-</script>
-
-<style>
-    button{ display: none }
-</style>
-
-<form onsubmit={handleSubmit} >
-    <input type="date" bind:value={date} />
-    <input type="time" bind:value={time} />
-    <button type="submit">ok</button>
-</form>
\ No newline at end of file
diff --git a/frontend/src/Components/TimeRecordEditor.svelte b/frontend/src/Components/TimeRecordEditor.svelte
new file mode 100644
index 0000000..8299f3a
--- /dev/null
+++ b/frontend/src/Components/TimeRecordEditor.svelte
@@ -0,0 +1,37 @@
+<script>
+    import { t }          from '../translations.svelte.js';
+    import MarkdownEditor from './MarkdownEditor.svelte';
+
+    let { record = null, onSet = time => {} } = $props();
+
+    function onsubmit(e){
+        e.preventDefault();
+        onSet(record);
+    }
+</script>
+
+{#if record}
+<form {onsubmit}>
+<fieldset>
+    <legend>{t('edit_object',{object:t('record')})}</legend>
+    <label>
+        {t('start')}
+        <input type="datetime-local" bind:value={record.start_time} />
+    </label>
+    <label>
+        {t('end')}
+        <input type="datetime-local" bind:value={record.end_time} />
+    </label>
+    <label>
+        {t('subject')}
+        <input type="text" bind:value={record.subject} />
+    </label>
+    <label>
+        {t('description')}
+        <MarkdownEditor simple={true} bind:value={record.description} />
+    </label>
+    <button type="submit">{t('save')}</button>
+</fieldset>
+</form>
+{record.description.source}
+{/if}
diff --git a/frontend/src/routes/time/Index.svelte b/frontend/src/routes/time/Index.svelte
index 1792739..a350633 100644
--- a/frontend/src/routes/time/Index.svelte
+++ b/frontend/src/routes/time/Index.svelte
@@ -4,14 +4,13 @@
     import { api }     from '../../urls.svelte.js';
     import { t }       from '../../translations.svelte.js';
 
-    import DateTimeEditor from '../../Components/DateTimeEditor.svelte';
-    import LineEditor     from '../../Components/LineEditor.svelte';
-    import MarkdownEditor from '../../Components/MarkdownEditor.svelte';
+    import TimeEditor from '../../Components/TimeRecordEditor.svelte';
 
     let error = $state(null);
     let router = useTinyRouter();
     let times = $state(null);
     let detail = $state(null);
+    let sortedTimes = $derived.by(() => Object.values(times).sort((b, a) => a.start_time.localeCompare(b.start_time)));
 
     async function loadTimes(){
         const url  = api('time');
@@ -27,17 +26,20 @@
         router.navigate(`task/${tid}/view`);
     }
 
-    async function update(tid,field,newVal){
-        times[tid][field] = newVal;
-        detail = null;
-        const url = api(`time/${tid}`);
+    async function update(time){
+        const url = api(`time/${time.id}`);
+        time.start_time = time.start_time.split(':').slice(0,2).join(':');
+        time.end_time = time.end_time.split(':').slice(0,2).join(':');
         const res = await fetch(url,{
             credentials:'include',
             method:'PATCH',
-            body:JSON.stringify(times[tid])
+            body:JSON.stringify(time)
         });
         if (res.ok){
-            times[tid] = await res.json();
+            let json = await res.json();
+            let id = json.id;
+            for (let key of Object.keys(json)) times[id][key] = json[key];
+            detail = null;
             error = null;
             return true;
         } else {
@@ -69,23 +71,15 @@
         </tr>
     </thead>
     <tbody>
-        {#each Object.entries(times) as [tid,time]}
-        {#if detail == tid}
+        {#each sortedTimes as time}
+        {#if detail == time.id}
         <tr>
-            <td>
-                <div>
-                    <DateTimeEditor value={time.start_time} onSet={dateTime => update(tid,'start_time',dateTime)} />
-                    …
-                    <DateTimeEditor value={time.end_time} onSet={dateTime => update(tid,'end_time',dateTime)} />
-                </div>
-            </td>
-            <td colspan="2">
-                <LineEditor     simple={true} value={time.subject} onSet={subject => update(tid,'subject',subject)} />
-                <MarkdownEditor simple={true} value={time.description} onSet={desc => update(tid,'description',desc)} />
+            <td colspan="5">
+                <TimeEditor record={time} onSet={update} />
             </td>
         </tr>
         {:else}
-        <tr onclick={e => {detail = tid}}>
+        <tr onclick={e => {detail = time.id}}>
             <td class="start_end">
                 {time.start_time}{#if time.end_time}…{time.end_time}{/if}
             </td>
diff --git a/translations/src/main/resources/de.json b/translations/src/main/resources/de.json
index d5a65cd..eeb83f4 100644
--- a/translations/src/main/resources/de.json
+++ b/translations/src/main/resources/de.json
@@ -173,6 +173,7 @@
   "project": "Projekt",
   "projects": "Projekte",
 
+  "record": "Eintrag",
   "repeat_new_password": "Wiederholung",
   "results": "Ergebnisse",